-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
CLN: factorize returns ndarray[intp], not int64 #40474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…nto typ-libs-factorize
any perf changes? are the XML changes orthogonal? (not objecting) |
same as the other PRs: should be neglible on 64bit, mixed on 32bit until we are internally consistent
i didnt do those, no idea how they got into the diff |
looks like the XML edits are already present in master, but just rebased, so hopefully they'll dissappear from the diff |
i guess general question then i agree aligning in intp is good mainly because we need to convert when we do a take |
on 64bit systems intp and int64 are the same and ensure_platform_int doesnt make a copy if it doesnt have to (and is in cython, so is cheap). on 32bit yes, we are going back-and-forth in some places but ATM it is too scattered to really track down (even if i had the hardware on hand) |
No description provided.